[webkit-reviews] review granted: [Bug 174654] [Curl] Move response related features into ResourceResponse : [Attachment 317179] Implemented

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 18 09:34:02 PDT 2017


Brent Fulgham <bfulgham at webkit.org> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 174654: [Curl] Move response related features into ResourceResponse
https://bugs.webkit.org/show_bug.cgi?id=174654

Attachment 317179: Implemented

https://bugs.webkit.org/attachment.cgi?id=317179&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 317179
  --> https://bugs.webkit.org/attachment.cgi?id=317179
Implemented

View in context: https://bugs.webkit.org/attachment.cgi?id=317179&action=review

This looks good to me. I wasn't sure if you meant to get rid of the notes about
the cURL FOLLOWLOCATION option. r=me, but not cq+ until you answer that.

> Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp:-721
> -	   // will be called more than one time with the line starting "HTTP"
for one job.

This information seems to have been lost in your patch. Is this no longer
relevant or useful to you?


More information about the webkit-reviews mailing list