[webkit-reviews] review granted: [Bug 175719] [GTK][WPE] ASSERTION FAILED: !isOpen() in WebKit::IconDatabase::~IconDatabase() : [Attachment 318492] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 175719: [GTK][WPE] ASSERTION FAILED: !isOpen() in
WebKit::IconDatabase::~IconDatabase()
https://bugs.webkit.org/show_bug.cgi?id=175719

Attachment 318492: Patch

https://bugs.webkit.org/attachment.cgi?id=318492&action=review




--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 318492
  --> https://bugs.webkit.org/attachment.cgi?id=318492
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318492&action=review

Nice!

> Source/WebKit/UIProcess/API/glib/IconDatabase.h:196
> +	       if (!m_timer.isActive())

I would add a blank line here.

> Source/WebKit/UIProcess/API/glib/IconDatabase.h:229
> +	   RunLoop::Timer<MainThreadNotifier> m_timer;

You're certain m_timer does not need to be guarded by a lock? Why not?