[webkit-reviews] review granted: [Bug 175443] [Beacon] Add support for quota limitation : [Attachment 318457] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 175443: [Beacon] Add support for quota limitation
https://bugs.webkit.org/show_bug.cgi?id=175443

Attachment 318457: Patch

https://bugs.webkit.org/attachment.cgi?id=318457&action=review




--- Comment #15 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 318457
  --> https://bugs.webkit.org/attachment.cgi?id=318457
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318457&action=review

> Source/WebKitLegacy/WebCoreSupport/WebResourceLoadScheduler.h:62
> +    void startPingLoad(WebCore::NetworkingContext*,
WebCore::ResourceRequest&, const WebCore::HTTPHeaderMap&,
Ref<WebCore::SecurityOrigin>&& sourceOrigin, WebCore::ContentSecurityPolicy*,
const WebCore::FetchOptions&, WTF::Function<void()>&& completionHandler)
override;

Should be final probably. Do we really need sourceOrigin parameter name here
also?

On another topic related to the handling of headers, do we have a test checking
referrer value after a cross-origin redirection and with a referrer policy like
origin-when-cross-origin?
Looking at the code, I am not sure we are doing the right thing here.