[webkit-reviews] review granted: [Bug 175274] Web Inspector: create better icon for Canvas Path navigation item : [Attachment 318453] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Matt Baker
<mattbaker at apple.com>'s request for review:
Bug 175274: Web Inspector: create better icon for Canvas Path navigation item
https://bugs.webkit.org/show_bug.cgi?id=175274

Attachment 318453: Patch

https://bugs.webkit.org/attachment.cgi?id=318453&action=review




--- Comment #5 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 318453
  --> https://bugs.webkit.org/attachment.cgi?id=318453
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318453&action=review

Please file a bug for Images/gtk. You may want to copy the PaintFlashing icon
as Path.svg for gtk until they have a replacement. It would be bad to have a
missing box icon.

> Source/WebInspectorUI/UserInterface/Images/Path.svg:6
> +    <path stroke="currentColor" fill="none" d="M 3 12 S 3 2 8 8 c 5.44 6.52
5-4 5-4"/>

This syntax is a little weird to me. I think the lowercase 'c' is important
(relative curve). The "5-4" is this actually "5 -4"? If so a space might be
helpful just for readability.