[webkit-reviews] review granted: [Bug 175697] Add a Unicode test to RexBench that matches non-BMP characters : [Attachment 318441] Patch

[bugzilla-daemon at webkit.org]

JF Bastien <jfbastien at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 175697: Add a Unicode test to RexBench that matches non-BMP characters
https://bugs.webkit.org/show_bug.cgi?id=175697

Attachment 318441: Patch

https://bugs.webkit.org/attachment.cgi?id=318441&action=review




--- Comment #3 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 318441
  --> https://bugs.webkit.org/attachment.cgi?id=318441
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318441&action=review

I didn't check the poker logic. I saw you play, looked about right.

r=me

> PerformanceTests/RexBench/unicode_poker_benchmark.js:51
> +    runUnicodePokerBenchmark = makeBenchmarkRunner(sources,
"UnicodePokerBenchmark", 20);

What's the 20 here? numIterations?

> PerformanceTests/RexBench/unicode_poker_benchmark.js:55
> +    name: "Unicode Poker",

UniPoker or Po🂾er

;-)

> PerformanceTests/RexBench/UnicodePoker/benchmark.js:36
> +	   Math.random = (function() {

Ha nice :)

> PerformanceTests/RexBench/UnicodePoker/benchmark.js:54
> +	   this._players.push(new Player("Player 4"));

Better player names! You could immortalized 4 people in benchmark fame!

> PerformanceTests/RexBench/UnicodePoker/poker.js:71
> +	   return cardRank

ASI on purpose here?

> PerformanceTests/RexBench/UnicodePoker/poker.js:128
> +	   });

Arrow function here!