[webkit-reviews] review denied: [Bug 175677] [Cache API] Add support for Cache.add/addAll : [Attachment 318380] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied youenn fablet
<youennf at gmail.com>'s request for review:
Bug 175677: [Cache API] Add support for Cache.add/addAll
https://bugs.webkit.org/show_bug.cgi?id=175677

Attachment 318380: Patch

https://bugs.webkit.org/attachment.cgi?id=318380&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 318380
  --> https://bugs.webkit.org/attachment.cgi?id=318380
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318380&action=review

> Source/WebCore/Modules/fetch/FetchResponse.h:98
> +    Variant<std::nullptr_t, RefPtr<FormData>, RefPtr<SharedBuffer>>
consumeBody();

This is not implemented, and if it were we could use Ref instead of RefPtr.

> Source/WebCore/Modules/fetch/FetchResponse.h:107
> +    static void startFetching(ScriptExecutionContext&, FetchRequest&,
std::optional<FetchPromise>&&, std::optional<EndOfLoad>&&);

My comment in https://bugs.webkit.org/show_bug.cgi?id=175658 applies here, too.