[webkit-reviews] review granted: [Bug 175610] Teach DFGFixupPhase.cpp that the current scope is always a cell : [Attachment 318421] Patch, with FTL fixed, now passes test locally

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 175610: Teach DFGFixupPhase.cpp that the current scope is always a cell
https://bugs.webkit.org/show_bug.cgi?id=175610

Attachment 318421: Patch, with FTL fixed, now passes test locally

https://bugs.webkit.org/attachment.cgi?id=318421&action=review




--- Comment #9 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 318421
  --> https://bugs.webkit.org/attachment.cgi?id=318421
Patch, with FTL fixed, now passes test locally

View in context: https://bugs.webkit.org/attachment.cgi?id=318421&action=review

r=me with some minor changes.

> Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:1717
> +	       fixEdge<KnownCellUse>(node->child1());

I would change this to ObjectUse and make a FIXME to add KnownObjectUse.

> Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:1723
> +	       fixEdge<KnownCellUse>(node->child1());

Ditto.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:1146
> +	   JSValueOperand object(this, node->child2());

Nit: this could be objectEdge.