[webkit-reviews] review granted: [Bug 175679] Regression(r220817): We should only copy the original request headers for Ping loads : [Attachment 318406] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 17 13:09:48 PDT 2017


youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 175679: Regression(r220817): We should only copy the original request
headers for Ping loads
https://bugs.webkit.org/show_bug.cgi?id=175679

Attachment 318406: Patch

https://bugs.webkit.org/attachment.cgi?id=318406&action=review




--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 318406
  --> https://bugs.webkit.org/attachment.cgi?id=318406
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318406&action=review

> Source/WebCore/loader/cache/CachedResource.cpp:276
> +	      
platformStrategies()->loaderStrategy()->createPingHandle(frame.loader().network
ingContext(), request, HTTPHeaderMap(*m_originalRequestHeaders), *m_origin,
contentSecurityPolicy, m_options);

IIRC, IPC is taking const& parameters.
WK2 createPingHandle could probably be implemented with just a const&.


More information about the webkit-reviews mailing list