[webkit-reviews] review granted: [Bug 175667] [WPE][GTK] Ensure proper casting of data in gvariants : [Attachment 318369] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Jacobo Aragunde Pérez
<jaragunde at igalia.com>'s request for review:
Bug 175667: [WPE][GTK] Ensure proper casting of data in gvariants
https://bugs.webkit.org/show_bug.cgi?id=175667

Attachment 318369: Patch

https://bugs.webkit.org/attachment.cgi?id=318369&action=review




--- Comment #9 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 318369
  --> https://bugs.webkit.org/attachment.cgi?id=318369
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318369&action=review

Nice, thanks. Real shame we don't have static analysis to catch this sort of
problem.

> Source/WebKit/UIProcess/API/glib/WebKitWebViewSessionState.cpp:174
> -    g_variant_builder_add(sessionBuilder, "d", frameState.pageScaleFactor);
> +    g_variant_builder_add(sessionBuilder, "d",
static_cast<gdouble>(frameState.pageScaleFactor));

I'm a bit concerned because this affected serialized session state, but not
much we can do about that.