[webkit-reviews] review denied: [Bug 175668] [GStreamer] AppendPipeline: support dispatch of decryption-specific GstStructure intothe pipeline : [Attachment 318353] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has denied Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 175668: [GStreamer] AppendPipeline: support dispatch of decryption-specific
GstStructure intothe pipeline
https://bugs.webkit.org/show_bug.cgi?id=175668

Attachment 318353: Patch

https://bugs.webkit.org/attachment.cgi?id=318353&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 318353
  --> https://bugs.webkit.org/attachment.cgi?id=318353
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318353&action=review

> Source/WebCore/ChangeLog:3
> +	   [GStreamer] AppendPipeline: support dispatch of decryption-specific
GstStructure intothe pipeline

intothe

> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h:-95
> -private:

Oops?

> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h:155
> +    GstStructure* m_pendingDecryptionStructure { nullptr };

Let's make this a GRefPtr.