[webkit-reviews] review granted: [Bug 175615] Update to changeSelectionWithTouchAt:baseIsStart:withFlags: : [Attachment 318219] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 175615: Update to changeSelectionWithTouchAt:baseIsStart:withFlags:
https://bugs.webkit.org/show_bug.cgi?id=175615

Attachment 318219: Patch

https://bugs.webkit.org/attachment.cgi?id=318219&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 318219
  --> https://bugs.webkit.org/attachment.cgi?id=318219
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318219&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2551
> +	   selectionChangedWithGesture(self, point, gestureType, gestureState,
flags | innerFlags, error);

are the flags handed back from selectWithGesture UIWKSelectionFlags? why are we
ORing them together? should we pass flags into selectWithGesture and then back
out, instead? it's kind of unusual to smush them together like this (but maybe
it makes sense?)