[webkit-reviews] review granted: [Bug 175631] [Mac/iOS] Increase the audio buffer size when audio capture is on but web audio is not used : [Attachment 318273] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 175631: [Mac/iOS] Increase the audio buffer size when audio capture is on
but web audio is not used
https://bugs.webkit.org/show_bug.cgi?id=175631

Attachment 318273: Patch

https://bugs.webkit.org/attachment.cgi?id=318273&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 318273
  --> https://bugs.webkit.org/attachment.cgi?id=318273
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318273&action=review

You should also remove the call to setPreferredBufferSize in
AudioDestinationIOS::configure

> Source/WebCore/ChangeLog:9
> +	   (PlatformMediaSessionManager::updateSessionState): Change value from
128 to the equivalent of 20ms when audio capture happens but not web audio.

Nit: this line should be wrapped.

> Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.cpp:48
> +	  
AudioSession::sharedSession().setPreferredBufferSize(AudioSession::sharedSessio
n().sampleRate() / 50);

Why calculate the size based on the sample rate in only this case? I think we
should either calculate them all, or set this one to 1024 (the nearest power of
2 above 20ms for 44K).