[webkit-reviews] review granted: [Bug 175599] [Cache API] Implement Worker connection to the Cache storage engine : [Attachment 318287] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 175599: [Cache API] Implement Worker connection to the Cache storage engine
https://bugs.webkit.org/show_bug.cgi?id=175599

Attachment 318287: Patch

https://bugs.webkit.org/attachment.cgi?id=318287&action=review




--- Comment #7 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 318287
  --> https://bugs.webkit.org/attachment.cgi?id=318287
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318287&action=review

r=me

> Source/WebCore/Modules/cache/CacheStorageConnection.cpp:83
> +    uint64_t requestIdentifier = ++m_requestCounter;

nit: m_requestCounter is a bit confusing as it is used as a way to generate
identifiers, not *count* requests. Maybe m_lastRequestIdentifier ?

> Source/WebCore/Modules/cache/CacheStorageConnection.cpp:131
> +    auto callback =
m_openAndRemoveCachePendingRequests.take(requestIdentifier);

Could be inside the if condition

> Source/WebCore/Modules/cache/CacheStorageConnection.cpp:138
> +    auto callback = m_retrieveCachesPendingRequests.take(requestIdentifier);

ditto

> Source/WebCore/Modules/cache/CacheStorageConnection.cpp:145
> +    auto callback =
m_retrieveRecordsPendingRequests.take(requestIdentifier);

ditto

> Source/WebCore/Modules/cache/CacheStorageConnection.cpp:152
> +    auto callback =
m_batchDeleteAndPutPendingRequests.take(requestIdentifier);

ditto

> Source/WebCore/Modules/cache/CacheStorageConnection.cpp:159
> +    auto callback =
m_batchDeleteAndPutPendingRequests.take(requestIdentifier);

ditto