[webkit-reviews] review granted: [Bug 175265] [GTK][WPE] webkit_cookie_manager_delete_all_cookies doesn't delete the cookies if called before a web process is running : [Attachment 318242] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 16 10:29:58 PDT 2017


Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 175265: [GTK][WPE] webkit_cookie_manager_delete_all_cookies doesn't delete
the cookies if called before a web process is running
https://bugs.webkit.org/show_bug.cgi?id=175265

Attachment 318242: Patch

https://bugs.webkit.org/attachment.cgi?id=318242&action=review




--- Comment #9 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 318242
  --> https://bugs.webkit.org/attachment.cgi?id=318242
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318242&action=review

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1191
> -    return &processPool.websiteDataStore().websiteDataStore() == this;
> +    return &processPool.websiteDataStore().websiteDataStore() == this ||
m_associatedProcessPools.contains(&processPool);

This is the magic line that makes everything work, right? How does this avoid
the network process being unnecessarily spawned?


More information about the webkit-reviews mailing list