[webkit-reviews] review granted: [Bug 175596] Make DataTransferItemList work with plain text entries : [Attachment 318201] Addressed review comments

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 175596: Make DataTransferItemList work with plain text entries
https://bugs.webkit.org/show_bug.cgi?id=175596

Attachment 318201: Addressed review comments

https://bugs.webkit.org/attachment.cgi?id=318201&action=review




--- Comment #5 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 318201
  --> https://bugs.webkit.org/attachment.cgi?id=318201
Addressed review comments

View in context: https://bugs.webkit.org/attachment.cgi?id=318201&action=review

> Source/WebCore/ChangeLog:8
> +	   Added the basic machinary to get the list of plain text items to
DataTransferItemList and DataTransferItem.

Nit - s/machinary/machinery/

> Source/WebCore/dom/DataTransferItem.cpp:69
> +    String value = m_dataTransfer.getData(m_type);

Nit - auto

> Source/WebCore/dom/DataTransferItemList.cpp:83
> +	   File& file = *files.item(i);

Nit - I think these would be more elegant as auto& file and auto type.

> LayoutTests/ChangeLog:10
> +	   Unfortunately, dropping a file is only supported by DumpRenderTree
on Mac :( so it's disabled elsewhere.

We already have existing iOS drag and drop tests that access the DataTransfer's
FileList on drop (event.dataTransfer.files), so I would think we should also be
able to use items there. An iOS DnD test would be nice, but probably in a
followup when we start iterating on iOS.