[webkit-reviews] review granted: [Bug 175584] We are too conservative about the effects of PushWithScope : [Attachment 318210] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 175584: We are too conservative about the effects of PushWithScope
https://bugs.webkit.org/show_bug.cgi?id=175584

Attachment 318210: Patch

https://bugs.webkit.org/attachment.cgi?id=318210&action=review




--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 318210
  --> https://bugs.webkit.org/attachment.cgi?id=318210
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318210&action=review

> Source/JavaScriptCore/dfg/DFGClobberize.h:475
> +	   read(ScopeProperties);

This is not the case, this node does not read ScopeProperties. This heap kind
is for GetClosureVar, PutClosureVar.

Also, please add tests that stress the CSE this opens up.