[webkit-reviews] review granted: [Bug 175581] Add Offline Assembler parsing test to RexBench : [Attachment 318138] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 175581: Add Offline Assembler parsing test to RexBench
https://bugs.webkit.org/show_bug.cgi?id=175581

Attachment 318138: Patch

https://bugs.webkit.org/attachment.cgi?id=318138&action=review




--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 318138
  --> https://bugs.webkit.org/attachment.cgi?id=318138
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318138&action=review

r=me

> PerformanceTests/ChangeLog:16
> +	   The input data is the current tip of tree LLInt .asm source files. 
Those file
> +	   were converted to JavaScript using the python script,
convert_asm_to_js.py.
> +	   There is also a new JavaScript file, generate_expected.js, to create
the
> +	   expected output JavaScript file.

How much faster is this than the ruby version?

> PerformanceTests/RexBench/offline_assembler_benchmark.js:44
> +var results = [];
> +var benchmark = new OfflineAssemblerBenchmark();
> +var numIterations = 20;

I vote for `let` here

> PerformanceTests/RexBench/OfflineAssembler/parser.js:27
> +

It would be cool if you extended it to allow for unicode in some way (maybe in
the future)