[webkit-reviews] review denied: [Bug 175584] We are too conservative about the effects of PushWithScope : [Attachment 318133] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has denied Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 175584: We are too conservative about the effects of PushWithScope
https://bugs.webkit.org/show_bug.cgi?id=175584

Attachment 318133: Patch

https://bugs.webkit.org/attachment.cgi?id=318133&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 318133
  --> https://bugs.webkit.org/attachment.cgi?id=318133
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318133&action=review

> Source/JavaScriptCore/ChangeLog:7
> +

It's worth a sentence describing the reasoning here.

Given the semantics of PushWithScope, I think it's also worth changing
Clobberize and DoesGC (based on making Clobberize not report it clobbers
things).

Can you also add tests that would stress a few things:
- we CSE around a PushWithScope
- cases where PushWithScope throws an exception in the DFG because the "o" is
null/undefined
- cases where PushWithScope allocates (e.g, the "o" is a number/string/Symbol)