[webkit-reviews] review granted: [Bug 175561] Enable named offsets into JSC bytecodes : [Attachment 318123] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 175561: Enable named offsets into JSC bytecodes
https://bugs.webkit.org/show_bug.cgi?id=175561

Attachment 318123: Patch

https://bugs.webkit.org/attachment.cgi?id=318123&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 318123
  --> https://bugs.webkit.org/attachment.cgi?id=318123
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318123&action=review

r=me with fixes.  Please rebase and get the EWS bots green before landing.

> Source/JavaScriptCore/ChangeLog:18
> +	   As a first cut I converted the various instanceof bytecodes to use
> +	   named offsets.

I think it is useful to include a sample of one such generated bytecode struct
here.  This will give the reader a much more intuitive sense of what this patch
does.

> Source/JavaScriptCore/generate-bytecode-files:133
> +    bytecodeHFile.write("friend class LLIntOffsetsExtractor;\n")

The "friend class ..." declaration should be indented by 4 spaces i.e. need to
add 4 spaces at start of string.