[webkit-reviews] review granted: [Bug 174993] Fix JSCOnly ARM buildbots after r220047 and r220184 : [Attachment 318061] Patch

[bugzilla-daemon at webkit.org]

Carlos Alberto Lopez Perez <clopez at igalia.com> has granted Csaba
Osztrogonác_OOO_until_21st_Aug <ossy at webkit.org>'s request for review:
Bug 174993: Fix JSCOnly ARM buildbots after r220047 and r220184
https://bugs.webkit.org/show_bug.cgi?id=174993

Attachment 318061: Patch

https://bugs.webkit.org/attachment.cgi?id=318061&action=review




--- Comment #16 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 318061
  --> https://bugs.webkit.org/attachment.cgi?id=318061
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318061&action=review

> Source/JavaScriptCore/CMakeLists.txt:1173
> +    elseif (ARM_TRADITIONAL_DETECTED)
> +	   set(OFFLINE_ASM_BACKEND "ARMv7_TRADITIONAL")
> +    endif ()
> +

Please add an extra "elseif" for MIPS

+ elseif (WTF_CPU_ARM64)
+      set(OFFLINE_ASM_BACKEND "MIPS")