[webkit-reviews] review denied: [Bug 175484] Add option to soft link CoreFoundation. : [Attachment 317943] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 175484: Add option to soft link CoreFoundation.
https://bugs.webkit.org/show_bug.cgi?id=175484

Attachment 317943: Patch

https://bugs.webkit.org/attachment.cgi?id=317943&action=review




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 317943
  --> https://bugs.webkit.org/attachment.cgi?id=317943
Patch

I'm not sure what the tangible benefit is.

This patch violates our usual approach for SPI usage, where we try hard to
re-declare the symbols, so that the build would fail when signatures don't
match. Mistakes in dynamically loaded function signatures and return types are
hard to investigate.