[webkit-reviews] review granted: [Bug 175546] XHR should only fire an abort event if the cancellation was requested by the client : [Attachment 318079] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 175546: XHR should only fire an abort event if the cancellation was
requested by the client
https://bugs.webkit.org/show_bug.cgi?id=175546

Attachment 318079: Patch

https://bugs.webkit.org/attachment.cgi?id=318079&action=review




--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 318079
  --> https://bugs.webkit.org/attachment.cgi?id=318079
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318079&action=review

> Source/WebCore/xml/XMLHttpRequest.cpp:1009
> +    // The XHR specification says we should only fire an abort event if the
cancelation was requested by the client.

Not sure this comment is needed.

For cancellation errors that are not due to client, they are probably due to
some safety security nets.
Would it make sense to long them in the console or is it redundant with web
inspector?

> LayoutTests/fast/frames/frame-unload-crash-expected.txt:-2
> -CONSOLE MESSAGE: line 13: XMLHttpRequest cannot load
frame-unload-crash-2.html due to access control checks.

This comment might be useful if it is true.
It might indeed be that the below abort is due to access control checks.

> LayoutTests/http/tests/navigation/page-cache-xhr-in-pagehide.html:65
> +    xhr.send();*/

This code is commented out.
Would this test be useful as WPT?