[webkit-reviews] review granted: [Bug 175549] Add some convenience utility accessor methods to MacroAssembler::CPUState. : [Attachment 318075] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 14 15:39:48 PDT 2017


Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 175549: Add some convenience utility accessor methods to
MacroAssembler::CPUState.
https://bugs.webkit.org/show_bug.cgi?id=175549

Attachment 318075: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=318075&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 318075
  --> https://bugs.webkit.org/attachment.cgi?id=318075
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=318075&action=review

> Source/JavaScriptCore/assembler/MacroAssembler.h:1869
> +    template<typename T, typename
std::enable_if<std::is_pointer<T>::value>::type* = nullptr>

I don't think you need the = nullptr and the * type.


More information about the webkit-reviews mailing list