[webkit-reviews] review granted: [Bug 175487] Add testing tool to lie to the DFG about profiles : [Attachment 318057] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 175487: Add testing tool to lie to the DFG about profiles
https://bugs.webkit.org/show_bug.cgi?id=175487

Attachment 318057: Patch

https://bugs.webkit.org/attachment.cgi?id=318057&action=review




--- Comment #12 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 318057
  --> https://bugs.webkit.org/attachment.cgi?id=318057
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318057&action=review

r=me

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:204
> +	   forNode(node) = forNode(node->child1());

I would just lump this into Identity since we don't run AI before fixup

> Source/JavaScriptCore/dfg/DFGNodeType.h:51
> +    macro(IdentityWithProfile, NodeResultJS) \

I would say MustGenerate here and then clear that bit in fixup