[webkit-reviews] review granted: [Bug 173457] Consider allow gUM to be called from localhost without https : [Attachment 318060] Proposed patch.

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 173457: Consider allow gUM to be called from localhost without https
https://bugs.webkit.org/show_bug.cgi?id=173457

Attachment 318060: Proposed patch.

https://bugs.webkit.org/attachment.cgi?id=318060&action=review




--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 318060
  --> https://bugs.webkit.org/attachment.cgi?id=318060
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=318060&action=review

> Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:105
> +    return equalLettersIgnoringASCIICase(response.url().host(),
"localhost");

So only localhost and not 127.0.0.1?
Do you know what other browsers are doing?

> Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:111
> +    if (requiresSecureConnection && !isSecure(*document.loader()) &&
!isLocalhost(*document.loader())) {

Geolocation is not allowing localhost/127.0.0.1 but it is accepting file URLs.
I wonder whether we should not make these two consistent.
If so, we should come up with a common routine.