[webkit-reviews] review granted: [Bug 175382] Parse font-display : [Attachment 317787] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 175382: Parse font-display
https://bugs.webkit.org/show_bug.cgi?id=175382

Attachment 317787: Patch

https://bugs.webkit.org/attachment.cgi?id=317787&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 317787
  --> https://bugs.webkit.org/attachment.cgi?id=317787
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317787&action=review

> Source/WebCore/css/CSSFontFace.cpp:409
> +    iterateClients(m_clients, [&](Client& client) {
> +	   client.fontPropertyChanged(*this);
> +    });

Should you detect whether it's being set to the existing values, and therefore
hasn't changed?

> Source/WebCore/css/CSSValueKeywords.in:1354
> +swap
> +fallback
> +optional

We usually list them all, and comment out the replicated ones.