[webkit-reviews] review granted: [Bug 174710] WebDriver: handle click events on option elements : [Attachment 318034] Updated patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 174710: WebDriver: handle click events on option elements
https://bugs.webkit.org/show_bug.cgi?id=174710

Attachment 318034: Updated patch

https://bugs.webkit.org/attachment.cgi?id=318034&action=review




--- Comment #13 from Brian Burg <bburg at apple.com> ---
Comment on attachment 318034
  --> https://bugs.webkit.org/attachment.cgi?id=318034
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318034&action=review

enthusiastic r=me!

> Source/WebKit/UIProcess/Automation/Automation.json:437
> +		   { "name": "browsingContextHandle", "$ref":
"BrowsingContextHandle", "description": "The handle for the browsing context."
},

Nit: you can just omit these comments if they don't add much.

> Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp:509
> +static WebCore::Element* elementContainer(WebCore::Element& element)

Nit: maybe containerElementForElement() to make it read better...

> Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp:559
> +    auto* containerElement = elementContainer(*coreElement);

... down here.