[webkit-reviews] review granted: [Bug 175530] Factor text autosizing into a class : [Attachment 318033] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 14 05:14:33 PDT 2017


Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 175530: Factor text autosizing into a class
https://bugs.webkit.org/show_bug.cgi?id=175530

Attachment 318033: patch

https://bugs.webkit.org/attachment.cgi?id=318033&action=review




--- Comment #3 from Andreas Kling <akling at apple.com> ---
Comment on attachment 318033
  --> https://bugs.webkit.org/attachment.cgi?id=318033
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318033&action=review

r=me

> Source/WebCore/rendering/TextAutoSizing.h:128
> +    using NodeMap = HashMap<TextAutoSizingKey,
std::unique_ptr<TextAutoSizingValue>, TextAutoSizingHash,
TextAutoSizingTraits>;
> +    NodeMap m_textNodes;

Seems like this could be accomplished in a single line, no?


More information about the webkit-reviews mailing list