[webkit-reviews] review granted: [Bug 172448] [ThreadedCompositor] Improve composition and update state handling : [Attachment 317924] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 172448: [ThreadedCompositor] Improve composition and update state handling
https://bugs.webkit.org/show_bug.cgi?id=172448

Attachment 317924: Patch

https://bugs.webkit.org/attachment.cgi?id=317924&action=review




--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 317924
  --> https://bugs.webkit.org/attachment.cgi?id=317924
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317924&action=review

Excellent comments, it's a lot easier to follow now. Thanks!

>
Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.
cpp:186
> +void CompositingRunLoop::compositionCompleted(LockHolder& stateLocker)

Why does this receive the lock if it's unused, is it just to make sure the
caller always calls this with the lock held?