[webkit-reviews] review granted: [Bug 175512] [ARM64] Use x29 and x30 instead of fp and lr to make GCC happy : [Attachment 318001] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Csaba Osztrogonác_OOO_until_21st_Aug
<ossy at webkit.org>'s request for review:
Bug 175512: [ARM64] Use x29 and x30 instead of fp and lr to make GCC happy
https://bugs.webkit.org/show_bug.cgi?id=175512

Attachment 318001: Patch

https://bugs.webkit.org/attachment.cgi?id=318001&action=review




--- Comment #9 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 318001
  --> https://bugs.webkit.org/attachment.cgi?id=318001
Patch

r=me.  Please put a comment in ctiMasmProbeTrampoline to explain that why we're
using x29 and x30, something like: "We use x29 and x30 instead of fp and lr
because gcc's inline assembler does not recognize fp and lr."  This will
minimize the chance that someone will change them back to sp and lr at a later
date unknowingly.