[webkit-reviews] review granted: [Bug 175366] FTL's compileGetTypedArrayByteOffset needs to do caging : [Attachment 317999] the patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 175366: FTL's compileGetTypedArrayByteOffset needs to do caging
https://bugs.webkit.org/show_bug.cgi?id=175366

Attachment 317999: the patch

https://bugs.webkit.org/attachment.cgi?id=317999&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 317999
  --> https://bugs.webkit.org/attachment.cgi?id=317999
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317999&action=review

> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:11653
> +	   LBasicBlock lastNext = m_out.insertNewBlocksBefore(notNull);

Why this instead of relying on the result of appendTo below?