[webkit-reviews] review granted: [Bug 175483] Caging shouldn't have to use a patchpoint for adding : [Attachment 317979] the patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 175483: Caging shouldn't have to use a patchpoint for adding
https://bugs.webkit.org/show_bug.cgi?id=175483

Attachment 317979: the patch

https://bugs.webkit.org/attachment.cgi?id=317979&action=review




--- Comment #4 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 317979
  --> https://bugs.webkit.org/attachment.cgi?id=317979
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317979&action=review

r=me

> Source/JavaScriptCore/ChangeLog:18
> +	   hoist it - that would require quite a bit of algebraic reasoning.
But this is the only case we know
> +	   where our current constant reassociation heuristics are wrong is
caging. So, we can get away with

/this is the only case we know where/the only case we know of where/.