[webkit-reviews] review denied: [Bug 175284] Web Inspector: allow recordings to be saved via ⌘-S in the Recording tab : [Attachment 317461] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has denied Devin Rousso <drousso at apple.com>'s
request for review:
Bug 175284: Web Inspector: allow recordings to be saved via ⌘-S in the
Recording tab
https://bugs.webkit.org/show_bug.cgi?id=175284

Attachment 317461: Patch

https://bugs.webkit.org/attachment.cgi?id=317461&action=review




--- Comment #2 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 317461
  --> https://bugs.webkit.org/attachment.cgi?id=317461
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317461&action=review

r-, since this duplicates code in RecordingNavigationSidebarPanel. The sidebar
should probably be using the new `saveData()` getter.

> Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js:99
> +	       forceSaveAs: true,

What are your thoughts on versioning?