[webkit-reviews] review granted: [Bug 175470] Support the with keyword in DFG : [Attachment 317944] Patch with Saam's suggestions

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 175470: Support the with keyword in DFG
https://bugs.webkit.org/show_bug.cgi?id=175470

Attachment 317944: Patch with Saam's suggestions

https://bugs.webkit.org/attachment.cgi?id=317944&action=review




--- Comment #8 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 317944
  --> https://bugs.webkit.org/attachment.cgi?id=317944
Patch with Saam's suggestions

View in context: https://bugs.webkit.org/attachment.cgi?id=317944&action=review

r=me with:
- a few comments below
- please add some tests that specifically stress `with` in the DFG

> Source/JavaScriptCore/ChangeLog:3
> +	   Support the 'which' keyword in DFG

typo: 'with' not 'which'

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:2066
> +	   // FIXME: Conservative

Please remove this FIXME or create a bug for it and link to the bugzilla here.
I'd vote for just removing it. I think it's ok to be conservative here.