[webkit-reviews] review granted: [Bug 175441] Make the WTF Encoder/Decoders appropriate for in-memory encoding (Don't always do the SHA1 checksumming) : [Attachment 317889] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 10 17:13:59 PDT 2017


Tim Horton <thorton at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 175441: Make the WTF Encoder/Decoders appropriate for in-memory encoding
(Don't always do the SHA1 checksumming)
https://bugs.webkit.org/show_bug.cgi?id=175441

Attachment 317889: Patch

https://bugs.webkit.org/attachment.cgi?id=317889&action=review




--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 317889
  --> https://bugs.webkit.org/attachment.cgi?id=317889
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317889&action=review

> Tools/TestWebKitAPI/Tests/WTF/Coding.cpp:62
> +// This should reliable capture a mistake where both encoders start doing
the extra work of checksumming

reliably


More information about the webkit-reviews mailing list