[webkit-reviews] review denied: [Bug 174394] Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI : [Attachment 316993] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 10 15:52:51 PDT 2017
Ryosuke Niwa <rniwa at webkit.org> has denied Frederik Riedel <riedel at apple.com>'s
request for review:
Bug 174394: Expose way to set values of classified form controls as {Legacy
WebKit, WebKit} SPI
https://bugs.webkit.org/show_bug.cgi?id=174394
Attachment 316993: Patch
https://bugs.webkit.org/attachment.cgi?id=316993&action=review
--- Comment #19 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 316993
--> https://bugs.webkit.org/attachment.cgi?id=316993
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=316993&action=review
r- given Wenson's comments and the fact EWS bots are all red.
I really don't think the code that assumes the username & password text fields
are the immediately successive focusable element belongs in WebKit.
> Source/WebCore/html/HTMLInputElement.cpp:919
> +URL HTMLInputElement::representingPageUrl()
> +{
> + return document().url();
> +}
We should just access input element's document() and then its url() in WebKit
layer instead of WebCore.
> Source/WebCore/html/HTMLInputElement.cpp:927
> + Element* previousElement =
document().previousFocusableElement(*start);
I don't think we should assume that the username and password text fields are
next to each other after start element.
Safari should just figure out which element is for username & which one is for
password and call [inputElement setValue] instead.
More information about the webkit-reviews
mailing list