[webkit-reviews] review granted: [Bug 175440] Apply the UNLIKELY macro to some unlikely things. : [Attachment 317843] proposed patch.

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <utatane.tea at gmail.com> has granted Mark Lam
<mark.lam at apple.com>'s request for review:
Bug 175440: Apply the UNLIKELY macro to some unlikely things.
https://bugs.webkit.org/show_bug.cgi?id=175440

Attachment 317843: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=317843&action=review




--- Comment #4 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 317843
  --> https://bugs.webkit.org/attachment.cgi?id=317843
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=317843&action=review

r=me

> Source/JavaScriptCore/bytecode/CodeBlock.cpp:1920
> +	   if (UNLIKELY(Profiler::Compilation* compilation =
jitCode()->dfgCommon()->compilation.get()))

IIRC, this does not work in some platforms (it causes compiling error). `if
(UNLIKELY(Type x = ...))`
Please check EWS. If EWS becomes green, ignore this comment :)

> Source/JavaScriptCore/ftl/FTLLink.cpp:71
> +    if (UNLIKELY(Profiler::Compilation* compilation = graph.compilation()))
{

Ditto.

> Source/JavaScriptCore/runtime/ScriptExecutable.cpp:160
> +	   if (UNLIKELY(Debugger* debugger =
genericCodeBlock->globalObject()->debugger()))

Ditto.