[webkit-reviews] review granted: [Bug 175241] Add ServiceWorkerJob : [Attachment 317778] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 10 10:46:29 PDT 2017


Tim Horton <thorton at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 175241: Add ServiceWorkerJob
https://bugs.webkit.org/show_bug.cgi?id=175241

Attachment 317778: Patch

https://bugs.webkit.org/attachment.cgi?id=317778&action=review




--- Comment #7 from Tim Horton <thorton at apple.com> ---
Comment on attachment 317778
  --> https://bugs.webkit.org/attachment.cgi?id=317778
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317778&action=review

> Source/WebCore/workers/ServiceWorkerJob.cpp:48
> +#ifndef NDEBUG

You shouldn't need these.

> Source/WebCore/workers/ServiceWorkerJob.cpp:55
> +#ifndef NDEBUG

You shouldn't need these.

> Source/WebCore/workers/ServiceWorkerJob.h:64
> +#ifndef NDEBUG

ASSERT_DISABLED


More information about the webkit-reviews mailing list