[webkit-reviews] review granted: [Bug 175378] [Soup] Cannot access HTTPS sites using a HTTP proxy that requires authentication : [Attachment 317812] Patch

[bugzilla-daemon at webkit.org]

Sergio Villar Senin <svillar at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 175378: [Soup] Cannot access HTTPS sites using a HTTP proxy that requires
authentication
https://bugs.webkit.org/show_bug.cgi?id=175378

Attachment 317812: Patch

https://bugs.webkit.org/attachment.cgi?id=317812&action=review




--- Comment #9 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 317812
  --> https://bugs.webkit.org/attachment.cgi?id=317812
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317812&action=review

Can't we come up with a test case?

> Source/WebCore/platform/network/soup/AuthenticationChallengeSoup.cpp:84
> +	   && a.soupAuth() == b.soupAuth();

One line?