[webkit-reviews] review granted: [Bug 175303] WKPreferences should conform to NSCopying : [Attachment 317751] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 10 08:14:09 PDT 2017
mitz at webkit.org has granted Brian Burg <bburg at apple.com>'s request for review:
Bug 175303: WKPreferences should conform to NSCopying
https://bugs.webkit.org/show_bug.cgi?id=175303
Attachment 317751: Patch
https://bugs.webkit.org/attachment.cgi?id=317751&action=review
--- Comment #7 from mitz at webkit.org ---
Comment on attachment 317751
--> https://bugs.webkit.org/attachment.cgi?id=317751
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=317751&action=review
> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Copying.mm:48
> + RetainPtr<WKPreferences> b = adoptNS([a.get() copy]);
Is it necessary to write .get() here?
More information about the webkit-reviews
mailing list