[webkit-reviews] review granted: [Bug 175211] [WTF] Move TextStream into WTF : [Attachment 317748] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 175211: [WTF] Move TextStream into WTF
https://bugs.webkit.org/show_bug.cgi?id=175211

Attachment 317748: Patch

https://bugs.webkit.org/attachment.cgi?id=317748&action=review




--- Comment #34 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 317748
  --> https://bugs.webkit.org/attachment.cgi?id=317748
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317748&action=review

I'm not an OWNER of the WebKit subproject, but just the change in pathnames
shouldn't require an OWNER. Aside from the "WTF::", it looks good to me.

> Source/WebCore/dom/ViewportArguments.h:148
> +WTF::TextStream& operator<<(WTF::TextStream&, const ViewportArguments&);

The WTF style is to say "using WTF::Foo;" at the bottom of WTF headers. Doing
this means you don't need "WTF::" sprayed over WebCore.

We chose a different style for PAL, and for now, we should keep the two styles
different. We may wish to change the style for WTF some time in the future, but
it should be its own discussion.