[webkit-reviews] review granted: [Bug 175175] [PAL] Move spi/cocoa and spi/cg directories into PAL : [Attachment 317640] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Yoshiaki Jitsukawa
<Yoshiaki.Jitsukawa at sony.com>'s request for review:
Bug 175175: [PAL] Move spi/cocoa and spi/cg directories into PAL
https://bugs.webkit.org/show_bug.cgi?id=175175

Attachment 317640: Patch

https://bugs.webkit.org/attachment.cgi?id=317640&action=review




--- Comment #7 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 317640
  --> https://bugs.webkit.org/attachment.cgi?id=317640
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317640&action=review

I'm not an OWNER of the WebKit subproject, but just the change in pathnames
shouldn't require an OWNER. Other than the style for the "*" character, this
looks good.

>
Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.hSource/WebCore/platform/spi/cocoa/AV
KitSPI.h:74
> + at property (nonatomic, readonly) AVPictureInPicturePlayerLayerView*
pictureInPicturePlayerLayerView;

Unfortunately, this is actually backwards. The style is:

For C and C++ types:
Type* foo;

For Objective-C types:
Type *foo;