[webkit-reviews] review requested: [Bug 175211] [WTF] Move TextStream into WTF : [Attachment 317748] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 9 15:45:21 PDT 2017
Don Olmstead <don.olmstead at sony.com> has asked for review:
Bug 175211: [WTF] Move TextStream into WTF
https://bugs.webkit.org/show_bug.cgi?id=175211
Attachment 317748: Patch
https://bugs.webkit.org/attachment.cgi?id=317748&action=review
--- Comment #33 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 317748
--> https://bugs.webkit.org/attachment.cgi?id=317748
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=317748&action=review
Bots that were failing are coming back as green so I think this is good to
review.
> Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp:104
> +
If this isn't moved Clang comes back with an error for an unused function.
Since DashArray is a typedef of a Vector it chooses Vector's operator << rather
than the specialized one. Moving it before writeNameValuePair rectifies this.
More information about the webkit-reviews
mailing list