[webkit-reviews] review granted: [Bug 175194] LayoutTest accessibility/presentation-role-iframe.html is a flaky failure : [Attachment 317735] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 9 15:24:26 PDT 2017


chris fleizach <cfleizach at apple.com> has granted Nan Wang <n_wang at apple.com>'s
request for review:
Bug 175194: LayoutTest accessibility/presentation-role-iframe.html is a flaky
failure
https://bugs.webkit.org/show_bug.cgi?id=175194

Attachment 317735: patch

https://bugs.webkit.org/attachment.cgi?id=317735&action=review




--- Comment #6 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 317735
  --> https://bugs.webkit.org/attachment.cgi?id=317735
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317735&action=review

r+ with style change

> LayoutTests/accessibility/presentation-role-iframe.html:33
> +var test1Log, test2Log, test3Log

semi-colon at the end?
also I think WebKit likes to put each variable on a separate line.

> LayoutTests/accessibility/presentation-role-iframe.html:62
> +    var result =  testNumber + ". Content child: " +
content.childAtIndex(0).role;

extra space after =


More information about the webkit-reviews mailing list