[webkit-reviews] review granted: [Bug 175391] Teach ScriptExecutionContexts about their SessionID : [Attachment 317726] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 9 12:05:10 PDT 2017
Andy Estes <aestes at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 175391: Teach ScriptExecutionContexts about their SessionID
https://bugs.webkit.org/show_bug.cgi?id=175391
Attachment 317726: Patch
https://bugs.webkit.org/attachment.cgi?id=317726&action=review
--- Comment #2 from Andy Estes <aestes at apple.com> ---
Comment on attachment 317726
--> https://bugs.webkit.org/attachment.cgi?id=317726
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=317726&action=review
> Source/WebCore/page/SessionID.cpp:61
> +SessionID SessionID::isolatedCopy() const
> +{
> + return SessionID { m_sessionID };
> +}
Seems like you could just do a regular copy-by-value in WorkerThreadStartupData
instead of adding this, since there's no actual isolated copying going on here.
More information about the webkit-reviews
mailing list