[webkit-reviews] review granted: [Bug 175388] LayoutTest http/wpt/beacon/keepalive-after-navigation.html is a flaky failure (harness timeout) : [Attachment 317716] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 175388: LayoutTest http/wpt/beacon/keepalive-after-navigation.html is a
flaky failure (harness timeout)
https://bugs.webkit.org/show_bug.cgi?id=175388

Attachment 317716: Patch

https://bugs.webkit.org/attachment.cgi?id=317716&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 317716
  --> https://bugs.webkit.org/attachment.cgi?id=317716
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317716&action=review

> LayoutTests/imported/w3c/web-platform-tests/beacon/beacon-navigate.html:12
> +    <script src="beacon-common.js?pipe=sub"></script>

Style only but it would be nicer to rename beacon-common.js as
beacon-common.sub.js and remove the ?pipe=sub

Looking at beacon-common.js, the polling mechanism seems fine.
I would tend though to stop polling and raise an error after a long timeout
like 5 seconds but I am not sure how WPT would like that change.