[webkit-reviews] review requested: [Bug 174817] [GStreamer] Refactor media player to use MediaTime consistently : [Attachment 317707] Patch

[bugzilla-daemon at webkit.org]

Charlie Turner <cturner at igalia.com> has asked  for review:
Bug 174817: [GStreamer] Refactor media player to use MediaTime consistently
https://bugs.webkit.org/show_bug.cgi?id=174817

Attachment 317707: Patch

https://bugs.webkit.org/attachment.cgi?id=317707&action=review




--- Comment #10 from Charlie Turner <cturner at igalia.com> ---
Created attachment 317707

  --> https://bugs.webkit.org/attachment.cgi?id=317707&action=review

Patch

It turned out after investigating that assertion that it does not make sense to
check for GST_SECOND, because we are not the only creators of media times, but
we can assume (and Apple ports do also) that the time is always fractional
seconds. Addressed other review comments.