[webkit-reviews] review granted: [Bug 175358] JSTests/stress/v8-deltablue-strict.js fails with JSC_validateExceptionChecks=1 : [Attachment 317665] Cleaned up patch, also avoids unnecessary re-throws

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 8 19:30:09 PDT 2017


Saam Barati <sbarati at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 175358: JSTests/stress/v8-deltablue-strict.js fails with
JSC_validateExceptionChecks=1
https://bugs.webkit.org/show_bug.cgi?id=175358

Attachment 317665: Cleaned up patch, also avoids unnecessary re-throws

https://bugs.webkit.org/attachment.cgi?id=317665&action=review




--- Comment #8 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 317665
  --> https://bugs.webkit.org/attachment.cgi?id=317665
Cleaned up patch, also avoids unnecessary re-throws

View in context: https://bugs.webkit.org/attachment.cgi?id=317665&action=review

r=me

> Source/JavaScriptCore/jit/JITOperations.cpp:1061
> +	   ASSERT(throwScope.exception() ==
reinterpret_cast<Exception*>(error));

Is this reinterpret_cast needed?


More information about the webkit-reviews mailing list