[webkit-reviews] review granted: [Bug 175347] JSTests/slowMicrobenchmarks/spread-small-array.js fails with JSC_validateExceptionChecks=1 : [Attachment 317631] Same patch, with the whitespace issues fixed

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 175347: JSTests/slowMicrobenchmarks/spread-small-array.js fails with
JSC_validateExceptionChecks=1
https://bugs.webkit.org/show_bug.cgi?id=175347

Attachment 317631: Same patch, with the whitespace issues fixed

https://bugs.webkit.org/attachment.cgi?id=317631&action=review




--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 317631
  --> https://bugs.webkit.org/attachment.cgi?id=317631
Same patch, with the whitespace issues fixed

View in context: https://bugs.webkit.org/attachment.cgi?id=317631&action=review

r=me with changelog fix

> Source/JavaScriptCore/ChangeLog:10
> +	   This is done by making finishCreation explicitely check for
exceptions after setConstantRegister and setConstantIdentifiersSetRegisters.
> +	   I chose to have this check replace the boolean returned previously
by these functions for readability. The performance impact should be
> +	   negligible considering how much more finishCreation does.
> +	   This fix then caused another issue to appear as it was now clear
that finishCreation can throw. And since it is called by
ProgramCodeBlock::create(),
> +	   FunctionCodeBlock::create() and friends, that are in turn called by
ScriptExecutable::newCodeBlockFor, this last function also required a few
tweaks.

Style nit: This explanation should go below the "Reviewed by ..."