[webkit-reviews] review granted: [Bug 175322] [WPE] Implement WebsiteDataStore::defaultApplicationCacheDirectory() and friends : [Attachment 317574] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 8 08:53:42 PDT 2017


Carlos Garcia Campos <cgarcia at igalia.com> has granted Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 175322: [WPE] Implement
WebsiteDataStore::defaultApplicationCacheDirectory() and friends
https://bugs.webkit.org/show_bug.cgi?id=175322

Attachment 317574: Patch

https://bugs.webkit.org/attachment.cgi?id=317574&action=review




--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 317574
  --> https://bugs.webkit.org/attachment.cgi?id=317574
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317574&action=review

> Source/WebKit/ChangeLog:22
> +2017-08-08  Adrian Perez de Castro  <aperez at igalia.com>

Double changelog.

> Source/WebKit/UIProcess/API/glib/APIWebsiteDataStoreGLib.cpp:37
> +#else
> +#error Invalid platform
> +#endif

forgot to say before, sorry, but don't do this, it will fail to compile anyway.


More information about the webkit-reviews mailing list